src: replace V8 Fast API todo comment with note comment #58614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Jun 7, 2025
anonrig
approved these changes
Jun 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58614 +/- ##
==========================================
+ Coverage 90.19% 90.21% +0.01%
==========================================
Files 636 636
Lines 187705 187718 +13
Branches 36852 36864 +12
==========================================
+ Hits 169306 169350 +44
+ Misses 11161 11120 -41
- Partials 7238 7248 +10
🚀 New features to boost your workflow:
|
jasnell
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jun 7, 2025
dario-piotrowicz
added
the
commit-queue
addaleax
approved these changes
Jun 7, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3596ee0 |
dario-piotrowicz
deleted the
dario/remove-v8-fast-api-revoke-obj-url-todo-comment
branch
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
PR-URL: nodejs#58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in #58544 adding a FAST V8 API version for the
Blob::RevokeObjectURLfunction does not produce a performance benefit, so I am replacing the codetodo comment with a note mentioning that using the FAST API for such function is not benficial